> -----Original Message-----
> From: Deng, KaiwenX <[email protected]>
> Sent: Tuesday, August 29, 2023 2:24 PM
> To: [email protected]
> Cc: [email protected]; Yang, Qiming <[email protected]>; Zhou, YidingX
> <[email protected]>; Deng, KaiwenX <[email protected]>;
> Zhang, Qi Z <[email protected]>; Xu, Ting <[email protected]>
> Subject: [PATCH] net/ice: fix tm configuration cannot be clear
>
> When the device is stopped, DPDK resets the commit flag so that we can
> update the hierarchy configuration.
Why we need to reset commit flag when device is stopped?
If the commit flag indicate all tm configure has been committed, stop device
does not change the status, its confusing to reset it.
Can we simply prevent additional commit when device is running by only checking
the stop flag? And why we reject a commit if its already committed?
> The commit flag is also used to determine
> if the hierarchy configuration needs to be cleared.
> When DPDK exits, it always stops the device first and also resets the commit
> flag result in the hierarchy configuration is not cleared.
>
> This patch adds a new flag "need_clear" to determine if the hierarchy
> configuration needs to be cleared.
>
> Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
> Cc: [email protected]
>
> Signed-off-by: Kaiwen Deng <[email protected]>
> ---
