> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 1 September 2023 16.24 > > When the user passes a list of desired drivers to build via the > "enable_drivers" option, the expectation is that those drivers should be > part of the build. However, if those drivers have either external or > internal dependencies, they still may be silently disabled, for example: > running "meson setup -Denable_drivers=net/iavf build" will successfully > run, but the iavf net driver will not be configured as "common/iavf" is > missing. > > We can fix this by setting a flag to indicate when the drivers are > specified via an enable_drivers flag. However, unlike when erroring out > on missing libs, we don't error out if a driver in unbuildable, unless > the driver name explicitly appears in the "enable_drivers" list. This is > implemented this way to ensure that wildcarding still works. For > example: we still want to allow "meson setup -Denable_drivers=net/*" to > work, configuring only the buildable network drivers. While it's true > that this additional restriction may cause some builds to pass when they > should fail, e.g. if the wildcard refers only to a single driver, > implementing things this way avoids massive amounts of complexity, and > is still an improvement on the status-quo. > > Suggested-by: Anatoly Burakov <anatoly.bura...@intel.com> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > ---
Acked-by: Morten Brørup <m...@smartsharesystems.com>
