Hi Brian,
> -----Original Message----- > From: Brian Dooley <brian.doo...@intel.com> > Sent: Thursday, September 7, 2023 11:26 AM > To: Akhil Goyal <gak...@marvell.com>; Fan Zhang <fanzhang....@gmail.com>; > Ji, Kai <kai...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com> > Cc: dev@dpdk.org; Dooley, Brian <brian.doo...@intel.com> > Subject: [PATCH v6 1/2] crypto/ipsec_mb: add digest encrypted feature > > AESNI_MB PMD does not support Digest Encrypted. This patch adds a check > and support for this feature. > > Signed-off-by: Brian Dooley <brian.doo...@intel.com> > --- > v2: > Fixed CHECKPATCH warning > v3: > Add Digest encrypted support to docs > v4: > Add comments and small refactor > v5: > Fix checkpatch warnings > v6: > Add skipping tests for synchronous crypto > --- > app/test/test_cryptodev.c | 6 ++ > doc/guides/cryptodevs/features/aesni_mb.ini | 1 + > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 109 > +++++++++++++++++++- > 3 files changed, 111 insertions(+), 5 deletions(-) > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > 956268bfcd..70f6b7ece1 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -6394,6 +6394,9 @@ test_zuc_auth_cipher(const struct > wireless_test_data *tdata, > tdata->digest.len) < 0) > return TEST_SKIPPED; > > + if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > + return TEST_SKIPPED; > + > rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > > uint64_t feat_flags = dev_info.feature_flags; @@ -7829,6 +7832,9 > @@ test_mixed_auth_cipher(const struct mixed_cipher_auth_test_data > *tdata, > if (global_api_test_type == CRYPTODEV_RAW_API_TEST) > return TEST_SKIPPED; > > + if (gbl_action_type == RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > + return TEST_SKIPPED; > + > rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); > <snip> Small thing, I think the above fixes should be in their own fix patch. Code changes look good to me. Can keep my ack on v7 with the fixes split out. Acked-by: Ciara Power <ciara.po...@intel.com>
