> -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: 22 September 2023 13:38 > To: Srikanth Yalavarthi <syalavar...@marvell.com> > Cc: Jerin Jacob <jerinjac...@gmail.com>; Prince Takkar > <ptak...@marvell.com>; dev@dpdk.org; Shivah Shankar Shankar Narayan > Rao <sshankarn...@marvell.com>; Anup Prabhu <apra...@marvell.com> > Subject: Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for > firmware read > > Hello, > > On Fri, Sep 22, 2023 at 5:59 AM Srikanth Yalavarthi > <syalavar...@marvell.com> wrote: > > > From: David Marchand <david.march...@redhat.com> On Thu, Sep 21, > > > 2023 at 3:06 PM Srikanth Yalavarthi <syalavar...@marvell.com> wrote: > > > > > > > archive. This causes the ML firmware binary to be parsed > > > > > > > incorrectly. > > > > > > > > > > > > + @David Marchand rte_firmware_read() author for his opinions > > > > > > Did you check that all 4 checks are failing individually or are you saying > this 4 > tests fail as a whole? > > I have one suspicion on archive_read_support_filter_xz, which may return > ARCHIVE_WARN.
Yes, archive_read_support_xz is returning ARCHIVE_WARN (-20). This is causing the firmware_open function to fail. I guess we can ignore the ARCHIVE_WARN, since this means about compression support, not decompression. ""These functions return ARCHIVE_OK if the compression is fully supported, ARCHIVE_WARN if the compression is supported only through an external program."" I have submitted a patch, which I have tested with compressed (xz) and uncompressed files. Please share your comments. http://patches.dpdk.org/project/dpdk/patch/20230922165356.31567-1-syalavar...@marvell.com/ > But that's my only serious hint so far. > > I have put up some debug patch, please have a try with it. > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__patchwork.dpdk.org_project_dpdk_patch_20230922080606.905222- > 2D1-2Ddavid.marchand- > 40redhat.com_&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=SNPqUkGl0n_ > Ms1iJa_6wD6LBwX8efL_NOyXvAX- > iCMI&m=gXmofsgJJekf5Jw2JIv1eESMDt3J_NyXqmHn9Gpk80XXWBsn7DBPjYsb > eghxAWQr&s=iwNgfFNxL60sMbI-OP-k78p45eUPFaWTN1kUsO4nguQ&e= Thanks for the debug patch and support. > > > -- > David Marchand
