On Fri, Sep 29, 2023 at 5:56 PM <sk...@marvell.com> wrote: > > From: Sunil Kumar Kori <sk...@marvell.com> > > In the continuation of following feedback > https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vattun...@marvell.com/ > this patch series adds dpdk-graph application to exercise various > usecases using graph. > > 1. Each use case is defined in terms of .cli file which will contain > set of commands to configure the system and to create a graph for > that use case. > > 2. Each module like ethdev, mempool, route etc exposes its set of commands > to do global and node specific configuration. > > 3. Command parsing is backed by command line library.
1) Please update the release notes for this new app. 2) Fix following issues ### [PATCH] app/graph: add telnet connectivity framework WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #205: FILE: app/graph/conn.c:162: + strncpy(conn->welcome, p->welcome, CONN_WELCOME_LEN_MAX); WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #206: FILE: app/graph/conn.c:163: + strncpy(conn->prompt, p->prompt, CONN_PROMPT_LEN_MAX); total: 0 errors, 2 warnings, 554 lines checked ### [PATCH] app/graph: add mempool command line interfaces WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #68: FILE: app/graph/mempool.c:32: + strcpy(mpconfig.config[nb_pools].name, config->name); WARNING:STRCPY: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #110: FILE: app/graph/mempool.c:74: + strcpy(config.name, res->name); ### [PATCH] app/graph: add graph command line interfaces WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over strncpy - see: https://github.com/KSPP/linux/issues/90 #166: FILE: app/graph/graph.c:113: + strncpy(graph_config.usecases[j].name, token, 31); WARNING:TYPO_SPELLING: 'Errot' may be misspelled - perhaps 'Error'? #269: FILE: app/graph/graph.c:216: + rte_exit(EXIT_FAILURE, "Errot in opening stats file\n"); ^^^^^
