> -----Original Message----- > From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Monday, October 16, 2023 7:41 PM > To: Jerin Jacob <jerinjac...@gmail.com> > Cc: Sunil Kumar Kori <sk...@marvell.com>; Rakesh Kudurumalla > <rkuduruma...@marvell.com>; dev@dpdk.org > Subject: [EXT] Re: [PATCH v8 05/12] app/graph: add ethdev command line > interfaces > > External Email > > ---------------------------------------------------------------------- > On Mon, Oct 16, 2023 at 06:50:47PM +0530, Jerin Jacob wrote: > > On Fri, Sep 29, 2023 at 3:29 PM <sk...@marvell.com> wrote: > > > > > > From: Sunil Kumar Kori <sk...@marvell.com> > > > > > > It adds ethdev module to configure ethernet devices. > > > > > > Following commands are exposed: > > > - ethdev <ethdev_name> rxq <n_queues> txq <n_queues> > <mempool_name> > > > - ethdev <ethdev_name> mtu <mtu_sz> > > > - ethdev <ethdev_name> promiscuous <on/off> > > > - ethdev <ethdev_name> show > > > - ethdev <ethdev_name> stats > > > - ethdev <ethdev_name> ip4 addr add <ip> netmask <mask> > > > - ethdev <ethdev_name> ip6 addr add <ip> netmask <mask> > > > - help ethdev > > > > > > Signed-off-by: Sunil Kumar Kori <sk...@marvell.com> > > > Signed-off-by: Rakesh Kudurumalla <rkuduruma...@marvell.com> > > > --- > > > > Acked-by: Jerin Jacob <jer...@marvell.com> > > Just FYI - if patchset [1] is merged, you could potentially save a lot of code > additions in this library by autogenerating the boilerplate for the > commandline. Maybe you could take a look and see if it could work for your > usecase here with commandline. If any cmdline features are missing with it, > it could be good to add them. > > /Bruce > > [1] https://urldefense.proofpoint.com/v2/url?u=http- > 3A__patches.dpdk.org_project_dpdk_list_-3Fseries- > 3D29852&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=dXeXaAMkP5COgn1z > xHMyaF1_d9IIuq6vHQO6NrIPjaE&m=0QfWbnzd1YwUIe2lmJkzpTQKlyPYvyxa > qnBpgZRGMKom4bq0WdLuiE1UkZHDdSub&s=AVLoaE4gWQ6VI7Rn61KYZx5cI > 14JGsmlylXv6NQOrqA&e=
Sure, I will check this after merging the changes. Currently I am planning to get this version merged as it is then later on once [1] is merged then I will send another patch to incorporate your suggestions.
