On 10/23/23 07:44, Juraj Linkeš wrote:
<snip>
My only nitpick comment would be on the name of the file common.py that
only contain the MesonArgs class. Looks good otherwise
Could you elaborate a bit more, Yoan? The common.py module is supposed
to be extended with code common to all other modules in the
testbed_model package. Right now we only have MesonArgs which fits in
common.py, but we could also move something else into common.py. We
also could rename common.py to something else, but then the above
purpose would not be clear.
I'm finishing the docstrings soon so expect a new version where things
like these will be clearer. :-)
My issue with the name is that it isn't clear what is the purpose of
this file. It only tell to some extend how it is used.
If we start adding more things in this file, then I see two options:
- Either this is related to the current class, and thus the file could
be named meson_arg or something along those lines.
- Or it is unrelated to the current class, and we end up with a file
coalescing random bits of code, which is usually a bit dirty in OOP.
Like I said, it's a bit of a nitpick, but given it's an RFC I hope
you'll give it a thought in the next version.
