Hi Simon, On 09/07/2015 02:50 PM, Simon Kagstrom wrote: > Chaining/segmenting mbufs can be useful in many places, so make it > global. > > Signed-off-by: Simon Kagstrom <simon.kagstrom at netinsight.net> > Signed-off-by: Johan Faltstrom <johan.faltstrom at netinsight.net> > > [...] > > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1775,6 +1775,40 @@ static inline int rte_pktmbuf_is_contiguous(const > struct rte_mbuf *m) > } > > /** > + * Chain an mbuf to another, thereby creating a segmented packet. > + * > + * Note: The implementation will do a linear walk over the segments to find > + * the tail entry. For cases when there are many segments, it's better to > + * chain the entries manually. > + * > + * @param head the head of the mbuf chain (the first packet) > + * @param tail the mbuf to put last in the chain > + * > + * @return 0 on success, -EOVERFLOW if the chain is full (256 entries) > + */
Small nit about the API comment, it should be: @param head The head of the mbuf chain (the first packet). ... (note the uppercase and the dot at the end, see the other functions in the file) I know Thomas usually fixes this kind of stuff when he pushes the patches, but it's better if we can avoid him this load :) Regards, Olivier