> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, October 2, 2015 12:38 AM > To: Richardson, Bruce; De Lara Guarch, Pablo > Cc: dev at dpdk.org; Stephen Hemminger > Subject: [PATCH] crc: deinline crc functions > > Because the CRC functions are inline and defined purely in the header > file, every component that uses these functions gets its own copy > of the software CRC table which is a big space waster. > > Just deinline which give better long term ABI stablity anyway. > > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
While I think it's a good idea to de-inline the functions that do the calculations using the lookup tables, I think the functions that consist of a single assembly instruction should be kept as inline. /Bruce