On Fri, Sep 22, 2023 at 1:49 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > Add a new driver to DPDK which supports taking in memory e.g. hugepage > memory via a unix socket connection and maps it into the DPDK process > replacing the current socket memory as the default memory for use by > future requests. > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
Thanks Bruce for this work. IMO, This will open up a lot of use cases like CPU based offload on different process. > + > +enum shared_mem_msg_type { > + MSG_TYPE_ACK = 0, > + MSG_TYPE_MMAP_BASE_ADDR, > + MSG_TYPE_MEMPOOL_OFFSET, > + MSG_TYPE_RX_RING_OFFSET, > + MSG_TYPE_TX_RING_OFFSET, > + MSG_TYPE_START, > + MSG_TYPE_GET_MAC, > + MSG_TYPE_REPORT_MAC, > +}; In order to cater to different use cases, IMO, drivers/bus/shared_mem/ should be generic and act only as transport for communicating with other process. That would translate to the following 1) drivers/bus/shared_mem/ provides means to register message type and its callback 2) The consumers(drivers/mempool/shared_mem and drivers/net/sharedmem) register the the callback. Definition the callback and message type should be in consumer. Also, We may change the bus/sharedmem to bus/socket or so, to limit the scope of bus driver as communion mechanism to talk to different process. That way there can different DPDK driver can based on socket bus in the future.