On 11/25/2023 1:47 AM, Huisong Li wrote: > The support for setting RSS hash algorithm has been introduced to 23.11, > but doesn't add feature for it. So this series add this feature and perfect > RSS other features by the way. > > In addition, serval features, like "set link up/down", "TM", "dump device > private information" and "loopback mode", had beed supported, but they are > absent from the freatures list. > > --- > -v3: > - fix description of the patchset cover > - remove '/features' in 'doc/features' tag for every patch. > - add Acked-by: Chengwen Feng <fengcheng...@huawei.com> > - retrigger CI build because of wrong CI warning > > -v2: > - add loopback mode feature. > > Huisong Li (6): > doc: add RSS hash algorithm feature > doc: add link up/down feature > doc: add features for link speeds > doc: add Traffic Manager feature > doc: add dump device private information feature > doc: add feature for loopback mode > >
Hi Huisong, Some of the patches above adds new features to the 'features.rst', but features.rst document describes features that drivers mark in feature list in .ini file, all features are listed in the 'default.ini'. When a new feature is added into 'default.ini', it can be described in 'features.rst' and later all driver .ini files should be updated to reflect if they support this feature or not. And I think no need to document all features, but ones can be important enough or differentiating features for users to know, this line is not easy to draw, so perhaps we can use community consensus to select. In this patch following features are added: - Link speed configuration - Traffic manager - Device private information dump - Loopback configuration I think 'Traffic manager' can be a new feature, but I am not sure about rest. It would be nice to get more comments.