On Fri, 15 Dec 2023 17:26:24 +0000 Euan Bourke <euan.bou...@intel.com> wrote:
> A recent thread on the mailing list[1] discussed corelist and coremask > parsing and the idea of a new library dedicated to command line parsing > was mentioned[2]. This patchset adds the library, along with the new > APIs, and edits the existing EAL, DLB2 driver and some example > application functions to use these APIs, rather than each implementing > their own copies. > > The new APIs work similar to the existing functions in EAL, however > instead of filling a core array like this: > [1, -1, -1, 2, 3] (a non -1 refers to an 'active core' at that index) > It fills it like this: > [0, 3, 4] (with the value at each index being an 'active core'). > > The new APIs will also return the number of cores contained in the > passed corelist/coremask, so in the above example, 3 would be returned. > > Also included in this patchest is a heuristic parser which searches > for key markers in the core string, returning a enum value based off > this search to indicate if a parameter is likely a coremask or a > corelist. This heuristic function is also wrapped in a parser > function allowing apps to handle both coremasks and corelists > simultaneously. > > [1] https://mails.dpdk.org/archives/dev/2023-November/280957.html > [2] https://mails.dpdk.org/archives/dev/2023-November/280966.html > The code is ok, but the naming needs to change. To me the name argparse implies that library implements something similar to Python argparse. But that isn't what this library does. It seems limited to just cpu masks. Perhaps cpuparse would be better name or make it part of a larger implementation of a full library more like Python argparse.
