Hi Stephen, We got that feedback from a couple of maintainers, so now we adhere to that rule. In the coding guideline this is not said explicitly but all the examples have periods at the end. So now we just follow that recommendation as gospel. Possibly it would help to say more explicitly in DPDK coding guidelines what is expected.
Thanks Nic > -----Original Message----- > From: Stephen Hemminger <step...@networkplumber.org> > Sent: Friday, January 5, 2024 2:01 PM > To: Vargas, Hernan <hernan.var...@intel.com> > Cc: dev@dpdk.org; gak...@marvell.com; Rix, Tom <t...@redhat.com>; > maxime.coque...@redhat.com; Chautru, Nicolas <nicolas.chau...@intel.com>; > Zhang, Qi Z <qi.z.zh...@intel.com> > Subject: Re: [PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment > changes > > On Fri, 5 Jan 2024 13:15:19 -0800 > Hernan Vargas <hernan.var...@intel.com> wrote: > > > Cosmetic changes for comments. > > No functional impact. > > > > Signed-off-by: Hernan Vargas <hernan.var...@intel.com> > > --- > > This is not helpful, there is no need for periods on every comment sentence.
