> -----Original Message----- > From: Morten Brørup <[email protected]> > Sent: Wednesday, January 24, 2024 20:01 > To: Ferruh Yigit <[email protected]>; Dariusz Sosnowski > <[email protected]>; Slava Ovsiienko <[email protected]>; Ori > Kam <[email protected]>; Suanming Mou <[email protected]>; Matan > Azrad <[email protected]>; Dmitry Kozlyuk <[email protected]> > Cc: [email protected]; [email protected]; [email protected] > Subject: RE: [PATCH v2 6/8] common/mlx5: fix calloc parameters > > > From: Ferruh Yigit [mailto:[email protected]] > > Sent: Wednesday, 24 January 2024 19.54 > > > > gcc [1] generates warning [2] about calloc usage, because calloc > > parameter order is wrong, fixing it by replacing parameters. > > > > [1] > > gcc (GCC) 14.0.1 20240124 (experimental) > > > > [2] > > Compiling C object .../common_mlx5_mlx5_common_mr.c.o > > .../mlx5/mlx5_common_mr.c: In function ‘mlx5_mempool_get_chunks’: > > .../common/mlx5/mlx5_common_mr.c:1384:29: > > warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier > > argument and not in the later argument [-Wcalloc-transposed-args] > > 1384 | *out = calloc(sizeof(**out), n); > > | ^ > > > > Fixes: 7297d2cdecce ("common/mlx5: fix external memory pool > > registration") > > Cc: [email protected] > > > > Signed-off-by: Ferruh Yigit <[email protected]> > > --- > > Acked-by: Morten Brørup <[email protected]>
Acked-by: Dariusz Sosnowski <[email protected]>

