On Wed, 21 Oct 2015 16:40:08 +0200 Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2015-09-30 10:30, Stephen Hemminger: > > On Wed, 30 Sep 2015 10:14:09 +0200 > > David Marchand <david.marchand at 6wind.com> wrote: > > > On Tue, Sep 29, 2015 at 2:44 AM, Stephen Hemminger < > > > stephen at networkplumber.org> wrote: > > > > It should be possible to build a single application or library > > > > that will work both in Xen and non-Xen environment. Any special > > > > case handling should be done at runtime. > > > > > > This patchset looks good, but can you go a step further and completely > > > remove the RTE_LIBRTE_XEN_DOM0 build option ? > > > This requires some more work (igb_uio, app/test), but I think this is > > > worth > > > it all the more so as you are looking into it at the moment. > > > > I was thinking that for people on embedded systems having > > the build option (which stubs out support) was a good thing. > > No we must remove the config options. > It is not in a hot path so there is no reason to disable this support. > Please respin. I looked into this, But Xen dom0 is a driver as well, and DPDK as is makes all the drivers optional. Also, we don't use Xen dom0 directly (only the net-front driver), and therefore do not have the infrastructure to test that driver.
