> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 4 April 2024 17.56 > > On Thu, 4 Apr 2024 17:37:53 +0200 > Morten Brørup <m...@smartsharesystems.com> wrote: > > > > I would tend to agree with Stephen that whereever possible we should use > > > the built-in memcpy calls. Hence my suggestion of re-introducing the > macro. > > > > I agree in principle, but strongly prefer data to back up such changes in > the fast path. > > > godbolt.org shows same instructions for the cases I looked at.
Such a fundamental change belongs in a separate patch, with a description of what has been confirmed to generate same instructions or otherwise tested. On behalf of the distros, I'm mostly worried about older compilers. Anyway, this patch also tidies up the code, removing a lot of copy-paste, so I think we should go ahead with this patch first.
