On Fri, Apr 05, 2024 at 04:45:55PM +0200, David Marchand wrote:
> ICE_TX_CTX_EIPT_NONE == 0.
> There is a good chance that !(anything & 0) is true :-).
>
> While removing this noop check is doable, let's check that the
> descriptor does contain a outer ip type.
>
> Fixes: 2ed011776334 ("net/ice: fix outer UDP Tx checksum offload")
>
> Signed-off-by: David Marchand <[email protected]>
> ---
Reviewed-by: Bruce Richardson <[email protected]>
- Re: [PATCH 1/8] net/ice: fix check for outer UDP c... David Marchand
- [PATCH 2/8] net/ice: enhance debug when HW fails to tra... David Marchand
- [PATCH 3/8] mbuf: fix Tx checksum offload examples David Marchand
- [PATCH 4/8] app/testpmd: fix outer IP checksum offload David Marchand
- [PATCH 5/8] net: fix outer UDP checksum in Intel prepar... David Marchand
- [PATCH 6/8] net/i40e: fix outer UDP checksum offload fo... David Marchand
- [PATCH 7/8] net/iavf: remove outer UDP checksum offload... David Marchand
- [PATCH 8/8] net: clear outer UDP checksum in Intel prep... David Marchand
- [PATCH v2 0/8] Fix outer UDP checksum for Intel nics David Marchand
- [PATCH v2 1/8] net/ice: fix check for outer UDP ch... David Marchand
- Re: [PATCH v2 1/8] net/ice: fix check for oute... Bruce Richardson
- [PATCH v2 2/8] net/ice: enhance debug when HW fail... David Marchand
- Re: [PATCH v2 2/8] net/ice: enhance debug when... Bruce Richardson
- Re: [PATCH v2 2/8] net/ice: enhance debug ... David Marchand
- Re: [PATCH v2 2/8] net/ice: enhance de... Bruce Richardson
- Re: [PATCH v2 2/8] net/ice: enhan... David Marchand
- [PATCH v2 3/8] mbuf: fix Tx checksum offload examp... David Marchand
- RE: [PATCH v2 3/8] mbuf: fix Tx checksum offlo... Morten Brørup
- Re: [PATCH v2 3/8] mbuf: fix Tx checksum o... David Marchand
- RE: [PATCH v2 3/8] mbuf: fix Tx checksum o... Konstantin Ananyev
- RE: [PATCH v2 3/8] mbuf: fix Tx checks... Morten Brørup

