> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, October 26, 2015 8:37 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo > server support > > Hi, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Saturday, October 24, 2015 10:24 PM > > To: De Lara Guarch, Pablo > > Cc: dev at dpdk.org; Thadeu Lima de Souza Cascardo > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo > > server support > > > > Pablo, opinion? > > Is the UDP echo eligible in testpmd to ease some tests? > > > > 2015-09-04 14:17, Thadeu Lima de Souza Cascardo: > > > Adapt the ICMP echo code to reply to UDP echo requests on port 7. The > > testpmd > > > forward engine udpecho is used for that. > > > > > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com> > > Sorry I missed this patch. Patch looks fine, but in my opinion, > it would be better to rename icmpecho to just echo, > and integrate UDP and TCP, with ICMP, as I think there is no need > to increase the number of forwarding modes for something so similar. >
Actually, I forgot to say that patch does not compile at least with gcc 5.1. Variables icmp_h and udp_h in reply_to_echo_rqsts() have to be initialized. > Pablo