On Wed, 1 May 2024 12:18:16 +0100
Ferruh Yigit <[email protected]> wrote:
> Thanks for reviving tap eBPF support, I am for merging this set (as
> early as possible).
>
> But I have two concerns,
> 1. Build environment header file dependencies and external library
> dependency version changed. Not sure if this will impact users.
> What do you think at least to update release notes to notify users?
Added a short note in release notes.
>
> 2. We need this to be tested, either by users or test teams. I will
> bring the issue in next release status meeting to see if we have anyone
> testing tap eBPF support.
Agreed. I ended up doing lots of manual tests. That is how it was
discovered that > 1 flow rule never worked with TAP.
There is a bigger issue here. There is no basic test suite for
PMD's. I see lots of differences creeping in with statistics etc.
And there is no test suite for rte_flow. Lots of untested code paths
and driver differences. Testing actual flows is hard, but basic
functional tests should be possible. Like:
- try all possible flow rules and actions
- make sure that any supported flow rule accepts a valid parameter.
and for those supported flow rules pass invalid data (like queue > nrx
queue).
- make sure validate and create work the same.
- make sure that validate doesn't actually create state in hw/sw.
should be possible to validate same rule 10,000 times without leaks
blowing up.
