BR
Rongwei ________________________________ From: Thomas Monjalon <[email protected]> Sent: Tuesday, June 4, 2024 19:59 To: rongwei liu <[email protected]> Cc: [email protected] <[email protected]>; Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Ori Kam <[email protected]>; Suanming Mou <[email protected]>; Dariusz Sosnowski <[email protected]>; Ferruh Yigit <[email protected]>; Andrew Rybchenko <[email protected]> Subject: Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field External email: Use caution opening links or attachments 27/05/2024 04:47, Rongwei Liu: > Add VXLAN last reserved byte in rte flow packet field. You should squash addition in testpmd in the same patch. Adding a field in rte_flow.h should be atomic with testpmd update. Sure. Squash into one commit. > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */ > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN reserved1. */ It isn't clear what reserved1 is. You should say it is the last byte of the VXLAN header. ACK.
