On 10/06/2024 15:24, Konstantin Ananyev wrote: [snip] > > With that changes in place: > Acked-by: Konstantin Ananyev <konstantin.anan...@huawei.com> > I have applied your comments in v15. [snip] >> + >> +size_t rte_mempool_get_obj_alignment(const struct rte_mempool *mp) >> +{ >> + if (mp == NULL) >> + return 0; > > In case of mp==NULL, would it be better to return negative error code > (-EINVAL or so)? > In that case the function should be changed to return ssize_t though. > I have chosen size_t for portability and ease of use as that is the type most likely expected by the caller and because there are no other error modes expected in the future that would require distinguishing between them. I hope this is an acceptable solution and have kept it in v15. [snip]
- [PATCH v14 0/6] add pointer compression API Paul Szczepanek
- [PATCH v14 1/6] lib: allow libraries with no sourc... Paul Szczepanek
- [PATCH v14 2/6] mempool: add functions to get extr... Paul Szczepanek
- RE: [PATCH v14 2/6] mempool: add functions to ... Konstantin Ananyev
- Re: [PATCH v14 2/6] mempool: add functions... Paul Szczepanek
- [PATCH v14 3/6] ptr_compress: add pointer compress... Paul Szczepanek
- Re: [PATCH v14 3/6] ptr_compress: add pointer ... David Marchand
- RE: [PATCH v14 3/6] ptr_compress: add poin... Morten Brørup
- Re: [PATCH v14 3/6] ptr_compress: add poin... Paul Szczepanek
- [PATCH v14 4/6] test: add pointer compress tests t... Paul Szczepanek
- [PATCH v14 5/6] docs: add pointer compression guid... Paul Szczepanek
- [PATCH v14 6/6] test: add unit test for ptr compre... Paul Szczepanek