On Wed, 28 Oct 2015 15:54:47 +0100 David Marchand <david.marchand at 6wind.com> wrote:
> Hello Jan, > > On Tue, Oct 27, 2015 at 8:13 PM, Jan Viktorin <viktorin at rehivetech.com> > wrote: > > > Hello DPDK community, > > > > this is the third attempt to post support for ARMv7 into the DPDK. > > There are changes related to the LPM and ACL libraries only: > > > > * included rte_vect.h, however, it is more a placeholder > > * rte_lpm.h was simplified due to the previous point > > * ACL now compiles as we detect whether the compiler > > supports SSE 4.1 > > > > This patchset looks good to me (with the minor comments I sent). > And armv8 support should fit quite well in this. > > A last few things : > - checkpatch is not happy with some patches, can you have a look at this ? I will check this. > - can you update the 2.2 release notes as part of this patchset to announce > armv7 support ? Yes, but where? > - I am not really sure the acl et lpm fixes really belong to this patchset > as a more larger cleanup is necessary to have all libraries compile fine on > non-x86 So, you mean to omit those and disable them all? The LPM and ACL fixes will be then included in 2.3? > - since you introduce a new architecture, do you intend to run daily build > checks and send reports to the test-report mailing list ? I think, this is possible, if I automate it somehow. Do you mean to test every individual patch? I have no tools for this (some ideas?). If its just about git pull && test_script.sh, then it is quite OK. I'd appreciate some help, ideas, advices, experiences in this area... > > > Thanks. > Jan -- Jan Viktorin E-mail: Viktorin at RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic