BR Rongwei
> -----Original Message----- > From: Ferruh Yigit <[email protected]> > Sent: Tuesday, June 11, 2024 22:53 > To: rongwei liu <[email protected]>; [email protected]; Matan Azrad > <[email protected]>; Slava Ovsiienko <[email protected]>; Ori Kam > <[email protected]>; Suanming Mou <[email protected]>; NBU- > Contact-Thomas Monjalon (EXTERNAL) <[email protected]> > Cc: Dariusz Sosnowski <[email protected]>; Aman Singh > <[email protected]>; Yuying Zhang <[email protected]>; > Andrew Rybchenko <[email protected]> > Subject: Re: [PATCH v8 2/3] ethdev: add VXLAN last reserved field > > External email: Use caution opening links or attachments > > > On 6/7/2024 3:02 PM, Rongwei Liu wrote: > > diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h index > > 997fc784fc..57300fb442 100644 > > --- a/lib/net/rte_vxlan.h > > +++ b/lib/net/rte_vxlan.h > > @@ -41,7 +41,10 @@ struct rte_vxlan_hdr { > > uint8_t flags; /**< Should be 8 (I flag). */ > > uint8_t rsvd0[3]; /**< Reserved. */ > > uint8_t vni[3]; /**< VXLAN identifier. */ > > - uint8_t rsvd1; /**< Reserved. */ > > + union { > > + uint8_t rsvd1; /**< Reserved. */ > > + uint8_t last_rsvd; /**< Reserved. */ > > + }; > > > > Is there a plan to remove 'rsvd1' in next ABI break release? > We can keep both, but I guess it is not logically necessary to keep it, to > prevent > bloat by time, we can remove the old one. > If decided to remove, sending a 'deprecation.rst' update helps us to remember > doing it. > I think it should. @NBU-Contact-Thomas Monjalon (EXTERNAL) @Andrew Rybchenko@Ori Kam what do you think?
