> On 4/26/24 09:48, Chaoyong He wrote:
> > From: Xinying Yu <xinying...@corigine.com>
> >
> > The ctrl words of vDPA is locate on the extend word, so should use the
> > 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'.
>
> located*
> extended*
>
> so it should*
>
Will fix in the v2 patch series.
Thanks for your review.
> >
> > Also replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro with
> > 'NFP_NET_CFG_CTRL_VIRTIO'.
> >
> > Fixes: b47a0373903f ("vdpa/nfp: add datapath update")
> > Cc: chaoyong...@corigine.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Xinying Yu <xinying...@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong...@corigine.com>
> > Reviewed-by: Long Wu <long...@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zh...@corigine.com>
> > ---
> > drivers/common/nfp/nfp_common_ctrl.h | 1 +
> > drivers/vdpa/nfp/nfp_vdpa_core.c | 16 ++++++++++++----
> > 2 files changed, 13 insertions(+), 4 deletions(-)
> >
>
> With commit message fixed (I can do it if only change needed in the
> series):
>
> Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
>
> Thanks,
> Maxime
