> On Fri, Jun 28, 2024 at 9:37 AM Chaoyong He <[email protected]> > wrote: > > > > From: Zerun Fu <[email protected]> > > > > In the previous logic the 'fd' was only saved in the primary process, > > but for some devices this value is also used in the secondary logic. > > > > For example, the call of 'rte_pci_find_ext_capability()' will fail in > > the secondary process. > > > > Fix this problem by getting and saving the value of 'fd' also in the > > secondary process logic. > > > > Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd") > > Cc: [email protected] > > Cc: [email protected] > > > > Signed-off-by: Zerun Fu <[email protected]> > > Reviewed-by: Chaoyong He <[email protected]> > > Reviewed-by: Long Wu <[email protected]> > > Reviewed-by: Peng Zhang <[email protected]> > > I did not enter in depth, but I wonder if this change leaks fd in a secondary > process when unmapping UIO resources. >
Yeah, it does have problem when unmapping UIO resources, and we will send a new version patch to fix it soon. Many thanks for your carefully review. > > -- > David Marchand
