03/07/2024 15:42, Volodymyr Fialko: > > From: Thomas Monjalon <tho...@monjalon.net> > > Sent: Wednesday, July 3, 2024 2:50 PM > > To: Volodymyr Fialko > > Cc: dev@dpdk.org; cristian.dumitre...@intel.com; Jerin Jacob; Anoob Joseph > > Subject: Re: [PATCH v5] bitmap: add scan from offset function > > > > 03/07/2023 14:39, Volodymyr Fialko: > > > Currently, in the case when we search for a bit set after a particular > > > value, the bitmap has to be scanned from the beginning and > > > rte_bitmap_scan() has to be called multiple times until we hit the value. > > > > > > Add a new rte_bitmap_scan_from_offset() function to initialize scan > > > state at the given offset and perform scan, this will allow getting > > > the next set bit after certain offset within one scan call. > > > > > > Signed-off-by: Volodymyr Fialko <vfia...@marvell.com> > > > --- > > > v2: > > > - added rte_bitmap_scan_from_offset > > > v3: > > > - added note for internal use only for init_at function > > > v4: > > > - marked init_at function as __rte_internal > > > v5: > > > - removed __rte_internal due to build errors > > > > What was the build error? > > > > You should not add an internal function in the public header file. > > At least, it should be experimental. > > > > From our discussion in previous versions(V3, V4), It looks like we agreed to > remove both markers.
Indeed, sorry I forgot this discussion.