Hi David, Hernan, This is not a fix per se (ie. no bug vulnerability), just keeping code consistent as the PMDs already set such unused queues to zero in the code (see existing code). Just keeping that existing coding style for the new operation for code consistency. We probably don’t have to fix on stable branch, so we may rephrase this commit as a cosmetic coding consistency change.
Thanks Nic > -----Original Message----- > From: David Marchand <david.march...@redhat.com> > Sent: Friday, July 12, 2024 5:26 AM > To: Vargas, Hernan <hernan.var...@intel.com> > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; > maxime.coque...@redhat.com; Chautru, Nicolas > <nicolas.chau...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com>; > sta...@dpdk.org > Subject: Re: [PATCH v1 1/1] drivers/baseband: fix device queues initialization > > On Mon, Jul 8, 2024 at 9:14 PM Hernan Vargas <hernan.var...@intel.com> > wrote: > > > > To prevent incorrect readings, initialize FFT and MLDTS queues to 0. > > All calls to bb drivers info_get are preceded with a: > memset(&dev_info, 0, sizeof(dev_info)); > dev->dev_ops->info_get(dev, &dev_info); > > So I don't really follow what this patch is trying to fix. > Can you provide details? > > > -- > David Marchand
