On Mon, Jul 22, 2024 at 8:33 PM Gowrishankar Muthukrishnan <gmuthukri...@marvell.com> wrote: > > Announce vhost ABI changes to modify few functions to support > asymmetric crypto operation. > > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukri...@marvell.com> > -- > RFC: > > https://patches.dpdk.org/project/dpdk/patch/20230928095300.1353-4-gmuthukri...@marvell.com/
Looks like in this case adding new arguments to function. Could you check ABI versing helps here? It seems like it can be easy manged with ABI versioning. https://doc.dpdk.org/guides/contributing/abi_versioning.html > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 6948641ff6..2f5c2c5a34 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -147,3 +147,10 @@ Deprecation Notices > will be deprecated and subsequently removed in DPDK 24.11 release. > Before this, the new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status. > + > +* vhost: The function ``rte_vhost_crypto_create`` will accept a new parameter > + to specify rte_mempool for asymmetric crypto session. The function > + ``rte_vhost_crypto_finalize_requests`` will accept two new parameters, > + where the first one is to specify vhost device id and other one is to > specify > + the virtio queue index. These two modifications are required to support > + asymmetric crypto operation in vhost crypto and will break ABI. > -- > 2.21.0 >
