On Mon, Aug 12, 2024 at 10:23 AM Dean Marx <dm...@iol.unh.edu> wrote: > > Add optional verify argument to the set_forward_mode > method in testpmd shell. > > Signed-off-by: Dean Marx <dm...@iol.unh.edu>
The patch all looks good to me, but it might be beneficial to add a "fixes" tag as well as a "bugzilla ID" tag to the commit body. The DPDK contribution guidelines explains how to format the tags [1] and also which order they should appear in [2]. [1] https://doc.dpdk.org/guides/contributing/patches.html#patch-fix-related-issues [2] https://doc.dpdk.org/guides/contributing/patches.html#tag-order > 2.44.0 >
