09/09/2024 14:04, Mattias Rönnblom: > What one should do is to have extern "C" linkage only on functions which > the include file in question (e.g., rte_foo.h) itself declares. > > -- > /* rte_bar.h */ > #include <rte_foo.h> > > #ifdef __cplusplus > extern "C" { > #endif > > void > rte_foo_do(void); > > /../ > -- > > There are 259 header files in the DPDK repo in need of fixing. > > Should the fix be 259 patches, or something smaller? One large patch, or > a patch per library, or something else. Please advise, over.
Moving includes in the whole tree can be done in a single patch, there is nothing specific per library in such a mechanical move.