On Mon, Sep 9, 2024 at 1:04 PM Bruce Richardson <[email protected]> wrote: > > Commit 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF"), > introduced a VF-reset adminq call into the reset sequence for iavf. > However, that call was very early in the sequence before other adminq > commands had been sent. > > To delay the VF reset, we can put the message sending in the "dev_close" > function, right before the adminq is shut down, and thereby guaranteeing > that we won't have any subsequent issues with adminq messages. > > In the process of making this change, we can also use the iavf_vf_reset > function from common/iavf, rather than hard-coding the message sending > lower-level calls in the net driver. > > Fixes: e74e1bb6280d ("net/iavf: enable port reset") > Fixes: 0f9ec0cbd2a9 ("net/iavf: fix VF reset when using DCF") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Bruce Richardson <[email protected]>
I see this patch is already merged, but as I was investigating iavf internals, I remembered this patch and relooked at it. Sending a reset request to the PF while closing the device seems saner to me. It also aligns the DPDK iavf driver behavior to the Linux kernel iavf driver. Reviewed-by: David Marchand <[email protected]> Thanks Bruce. -- David Marchand
