On Mon, 6 Nov 2023 07:31:19 +0000 Chengwen Feng <fengcheng...@huawei.com> wrote:
> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), > it also supports to parse only-key (e.g. socket_id). But many drivers's > callback can only handle key-value, it will segment fault if handles > only-key. so the patchset [1] was introduced. > > Because the patchset [1] modified too much drivers, therefore: > 1) A new API rte_kvargs_process_opt() was introduced, it inherits the > function of rte_kvargs_process() which could parse both key-value and > only-key. > 2) Constraint the rte_kvargs_process() can only parse key-value. > > This patchset also include one bugfix for kvargs of mvneta driver. > > [1] > https://patches.dpdk.org/project/dpdk/patch/20230320092110.37295-1-fengcheng...@huawei.com/ > > Chengwen Feng (5): > kvargs: add one new process API > net/sfc: use new API to parse kvargs > net/tap: use new API to parse kvargs > common/nfp: use new API to parse kvargs > net/mvneta: fix possible out-of-bounds write Not sure why the patchset never got more attention. Yes it is a real bug, and this looks like a reasonable way to address it. It does need to be rebased to current 24.11 tree to have a chance, and would be good to add more documentation to the API and remove cases in drivers that have unnecessary NULL checks after this. But those changes can be follow ups. Also the mvneta patch probably should be sent as separate it does not depend on anything here. Bottom line resubmit it, and I will ack the new version.
