> -----Original Message-----
> From: Kusztal, ArkadiuszX <[email protected]>
> Sent: Monday, October 7, 2024 9:20 AM
> To: Gowrishankar Muthukrishnan <[email protected]>;
> [email protected]; Akhil Goyal <[email protected]>; Fan Zhang
> <[email protected]>
> Cc: Anoob Joseph <[email protected]>; Richardson, Bruce
> <[email protected]>; [email protected]; Ji, Kai <[email protected]>;
> [email protected]; Marchand, David
> <[email protected]>; [email protected]; De Lara Guarch,
> Pablo <[email protected]>; Trahe, Fiona
> <[email protected]>; Doherty, Declan <[email protected]>;
> [email protected]; [email protected]; Gujjar, Abhinandan S
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Daly,
> Lee <[email protected]>; Dooley, Brian <[email protected]>
> Subject: RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax
>
> Acked with a small comment.
>
> > -----Original Message-----
> > From: Gowrishankar Muthukrishnan <[email protected]>
> > Sent: Friday, October 4, 2024 8:11 AM
> > To: [email protected]; Akhil Goyal <[email protected]>; Fan Zhang
> > <[email protected]>
> > Cc: Anoob Joseph <[email protected]>; Richardson, Bruce
> > <[email protected]>; [email protected]; Kusztal, ArkadiuszX
> > <[email protected]>; Ji, Kai <[email protected]>; jack.bond-
> > [email protected]; Marchand, David <[email protected]>;
> > [email protected]; De Lara Guarch, Pablo
> > <[email protected]>; Trahe, Fiona
> > <[email protected]>; Doherty, Declan <[email protected]>;
> > [email protected]; [email protected]; Gujjar, Abhinandan S
> > <[email protected]>; [email protected];
> > [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; Daly, Lee <[email protected]>; Dooley, Brian
> > <[email protected]>; Gowrishankar Muthukrishnan
> > <[email protected]>
> > Subject: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax
Additionally, it should not be a fix.
The RFC mandates usage of the ASN.1, but only in case sharing private key
across the network.
How the Cryptodev should interpret it, is up to the implementation.
> >
> > As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key would
> > need
> It could be RFC 8017 instead.
> > specification of quintuple along with private exponent.
> > It is up to the implementation to internally handle, but not at RTE
> > itself to make them exclusive each other. Removing union on them
> > allows asymmetric implementation in VirtIO to benefit from the xform as per
> ASN.1 syntax.
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <[email protected]>
> > ---
> > lib/cryptodev/rte_crypto_asym.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cryptodev/rte_crypto_asym.h
> > b/lib/cryptodev/rte_crypto_asym.h index 39d3da3952..c33be3b155 100644
> > --- a/lib/cryptodev/rte_crypto_asym.h
> > +++ b/lib/cryptodev/rte_crypto_asym.h
> > @@ -306,7 +306,7 @@ struct rte_crypto_rsa_xform {
> >
> > enum rte_crypto_rsa_priv_key_type key_type;
> >
> > - union {
> > + struct {
> > rte_crypto_uint d;
> > /**< the RSA private exponent */
> > struct rte_crypto_rsa_priv_key_qt qt;
> > --
> > 2.21.0
>
> Acked-by: Arkadiusz Kusztal <[email protected]>
