> Acked-by: Arkadiusz Kusztal <arkadiuszx. kusztal@ intel. com>
Thanks.
> With some comments.
>
<cut>
> > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > index b7b612fc57..6f81bcb110 100644
> > --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > @@ -598,15 +598,22 @@ static const struct rte_cryptodev_capabilities
> > openssl_pmd_capabilities[] = {
> > {.asym = {
> > .xform_capa = {
> > .xform_type =
> > RTE_CRYPTO_ASYM_XFORM_SM2,
> > - .hash_algos = (1 <<
> RTE_CRYPTO_AUTH_SM3),
> > .op_types =
> > - ((1<<RTE_CRYPTO_ASYM_OP_SIGN) |
> > + ((1 << RTE_CRYPTO_ASYM_OP_SIGN) |
> > (1 << RTE_CRYPTO_ASYM_OP_VERIFY) |
> > (1 << RTE_CRYPTO_ASYM_OP_ENCRYPT) |
> > (1 << RTE_CRYPTO_ASYM_OP_DECRYPT)),
> > - {.internal_rng = 1
> > - }
> > - }
> Designated initializers could probably help with readability.
> > + .op_capa = {
> > +
> [RTE_CRYPTO_ASYM_OP_ENCRYPT] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PKE_KDF),
> > +
> [RTE_CRYPTO_ASYM_OP_DECRYPT] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PKE_KDF),
> > +
> [RTE_CRYPTO_ASYM_OP_SIGN] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PH),
> > +
> [RTE_CRYPTO_ASYM_OP_VERIFY] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PH)
> > + },
> > + },
> > }
>
Ack.
> Probably driver/test changes should be in different patches.
>
Ack.
Regards,
Gowrishankar
