On 10/4/2024 8:18 PM, Dariusz Sosnowski wrote: >> -----Original Message----- >> From: Andrew Rybchenko <[email protected]> >> Sent: Friday, October 4, 2024 09:27 >> To: Ferruh Yigit <[email protected]>; NBU-Contact-Thomas Monjalon >> (EXTERNAL) <[email protected]>; Ori Kam <[email protected]>; Aman Singh >> <[email protected]>; Konstantin Ananyev >> <[email protected]>; Reshma Pattan <[email protected]>; >> Stephen Hemminger <[email protected]>; Akhil Goyal >> <[email protected]>; Anoob Joseph <[email protected]>; Potnuri Bharat >> Teja <[email protected]>; Hemant Agrawal <[email protected]>; >> Sachin Saxena <[email protected]>; Matan Azrad <[email protected]>; >> Slava Ovsiienko <[email protected]>; Dariusz Sosnowski >> <[email protected]>; Bing Zhao <[email protected]>; Suanming Mou >> <[email protected]>; Chaoyong He <[email protected]> >> Cc: [email protected]; Morten Brørup <[email protected]>; Bruce >> Richardson <[email protected]> >> Subject: Re: [PATCH] ethdev: convert string initialization >> >> External email: Use caution opening links or attachments >> >> >> On 10/4/24 07:13, Ferruh Yigit wrote: >>> gcc 15 experimental [1], with -Wextra flag, gives warning in variable >>> initialization as string [2]. >>> >>> The warning has a point when initialized variable is intended to use >>> as string, since assignment is missing the required null terminator >>> for this case. But warning is useless for our usecase. >>> >>> In this patch only updated a few instance to show the issue, there are >>> many instances to fix, if we prefer to go this way. >>> Other option is to disable warning but it can be useful for actual >>> string usecases, so I prefer to keep it. >>> >>> Converted string initialization to array initialization. >>> >>> [1] >>> gcc (GCC) 15.0.0 20241003 (experimental) >>> >>> [2] >>> ../lib/ethdev/rte_flow.h:906:36: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 906 | .hdr.dst_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:907:36: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 907 | .hdr.src_addr.addr_bytes = "\xff\xff\xff\xff\xff\xff", >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1009:25: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1009 | "\xff\xff\xff\xff\xff\xff\xff\xff" >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1012:25: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1012 | "\xff\xff\xff\xff\xff\xff\xff\xff" >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> ../lib/ethdev/rte_flow.h:1135:20: >>> error: initializer-string for array of ‘unsigned char’ is too long >>> [-Werror=unterminated-string-initialization] >>> 1135 | .hdr.vni = "\xff\xff\xff", >>> | ^~~~~~~~~~~~~~ >>> >>> Signed-off-by: Ferruh Yigit <[email protected]> >>> Acked-by: Morten Brørup <[email protected]> >>> Acked-by: Bruce Richardson <[email protected]> >> >> >> Acked-by: Andrew Rybchenko <[email protected]> > > Acked-by: Dariusz Sosnowski <[email protected]> >
Applied to dpdk-next-net/main, thanks.
