> On 9/18/2024 3:38 AM, Chaoyong He wrote: > > From: James Hershaw <james.hers...@corigine.com> > > > > Add command to change the state of a controllable LED on an ethdev > > port to on/off. This is for the purpose of identifying which physical > > port is associated with an ethdev. > > > > Usage: > > testpmd> set port <port-id> led <on/off> > > > > Signed-off-by: James Hershaw <james.hers...@corigine.com> > > Reviewed-by: Chaoyong He <chaoyong...@corigine.com> > > --- > > app/test-pmd/cmdline.c | 52 +++++++++++++++++++++ > > app/test-pmd/config.c | 20 ++++++++ > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ > > 4 files changed, 80 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > a227d3cdc5..a117a4c2fb 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -523,6 +523,10 @@ static void cmd_help_long_parsed(void > *parsed_result, > > " user is acknowledging and taking responsibility for" > > " this risk.\n\n" > > > > + "set port (port_id) led (on|off)\n" > > + " set a controllable LED associated with a certain" > > + " port on or off.\n\n" > > + > > > > new command seems added in between some mac related commands > (excluding new eeprom cmd, assuming it will be moved), as we don't have > anything related to the led before maybe it can go last. > Same comment for all updates in this patch, can you please double check the > order, and put updates in middle of other grouping.
Okay, we will send a new version patch.
