On 10/13/2024 1:53 AM, Stephen Hemminger wrote: > On Sun, 13 Oct 2024 00:53:54 +0100 > Ferruh Yigit <ferruh.yi...@amd.com> wrote: > >> On 10/12/2024 3:17 AM, Stephen Hemminger wrote: >>> Some patches related to recent queue limit changes. >>> >>> v2 - up the limit to maximum Linux can support >>> dont use static_assert here >>> get rid of unreachable checks in configure >>> >>> Stephen Hemminger (3): >>> net/tap: handle increase in mp_max_fds >>> net/tap: increase the maximum allowable queues >>> net/tap: remove unnecessary checks in configure >>> >> >> Hi Stephen, >> >> Previous version already merged, but I am checking the difference in v2. >> >> Patch 1/3 is identical. >> Patch 2/3, I prefer the v1 version, that increases the queue limit to >> 64, instead of 253. > > Ok, we can bump it later if anyone wants to run on 128 core cpu >
ack >> >> v1 patch 3/3 static assert seems gone, it seems because of the loongarch >> build, but can we please root cause why it failed, and can the failure >> be a test environment issue? > > Right, not sure what was wrong there, and not easy to setup a loongarch > build (even with qemu) to repro. > Indeed I was hoping to get some support from loongarch CI maintainers, instead of we setup an environment to test. As the patch is already merged in next-net, they should able to test & debug it. > >> v2 patch 3/3 looks good, it can be merged separately. > > Ok, will add it to later follow up set. The tap device driver needs > lots more cleanups. > I can merge the patch directly from this set, planning to check it soon.
