>-----Original Message-----
>From: David Marchand <[email protected]>
>Sent: Friday, October 11, 2024 3:29 PM
>To: Tomasz Duszynski <[email protected]>
>Cc: Jerin Jacob <[email protected]>; Sunil Kumar Kori <[email protected]>;
>Tyler Retzlaff
><[email protected]>; [email protected];
>[email protected]; [email protected];
>[email protected]; [email protected];
>[email protected];
>[email protected]; [email protected]; [email protected]
>Subject: [EXTERNAL] Re: [PATCH v14 4/4] eal: add PMU support to tracing library
>
>On Fri, Oct 11, 2024 at 11: 50 AM Tomasz Duszynski <tduszynski@ marvell. com>
>wrote: > diff --git
>a/lib/eal/meson. build b/lib/eal/meson. build > index e1d6c4cf17. . 2b1a1eb283
>100644 > ---
>a/lib/eal/meson. build > +++ b/lib/eal/meson. build
>On Fri, Oct 11, 2024 at 11:50 AM Tomasz Duszynski <[email protected]>
>wrote:
>> diff --git a/lib/eal/meson.build b/lib/eal/meson.build index
>> e1d6c4cf17..2b1a1eb283 100644
>> --- a/lib/eal/meson.build
>> +++ b/lib/eal/meson.build
>> @@ -14,7 +14,7 @@ subdir(exec_env)
>>
>> subdir(arch_subdir)
>>
>> -deps += ['log', 'kvargs']
>> +deps += ['log', 'kvargs', 'pmu']
>
>Quick comment as I saw a failure in CI.
>
>An optional library should not be a required dependency for EAL.
>You need something like (untested):
>
>if dpdk_conf.has('RTE_LIB_PMU')
> deps += ['pmu']
>endif
>
Okay, I'll double check. Thanks.
>> if not is_windows
>> deps += ['telemetry']
>> endif
>
>
>--
>David Marchand
