On Tue, 15 Oct 2024 17:11:43 +0000
Vladimir Medvedkin <[email protected]> wrote:

> Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its
> return value to align with the existing rte_fib API.
> 
> Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")
> 
> Signed-off-by: Vladimir Medvedkin <[email protected]>
> ---

Looks good, although DPDK often uses rte_errno, it is better for this part
in fib to be consistent across rcu and non-rcu variants.

PS: there don't seem to be any negative tests on this function in test_fib.c
would be good to hit some of the basics.

Reviewed-by: Stephen Hemminger <[email protected]>

Reply via email to