On 2024/10/18 22:46, Thomas Monjalon wrote: > 18/10/2024 03:09, fengchengwen: >> Hi Thomas and David, >> >> This patchset was already acked by Stephen. >> It missed in DPDK 24.07, hope merge in 24.11. >> >> Thanks >> >> On 2024/10/10 9:35, fengchengwen wrote: >>> Hi Thomas and David, >>> >>> Kindly ping for merge. >>> >>> On 2024/10/10 3:33, Stephen Hemminger wrote: >>>> On Mon, 18 Mar 2024 11:18:32 +0000 >>>> Chengwen Feng <fengcheng...@huawei.com> wrote: >>>> >>>>> I found a couple of issues when I revisited the argparse_autotest >>>>> output, so got this patchset. >>>>> >>>>> Chengwen Feng (6): >>>>> argparse: refine error message >>>>> argparse: remove dead code >>>>> argparse: replace flag enum with marco >>>>> argparse: fix argument flags operate as uint32 type >>>>> test/argparse: refine testcases >>>>> argparse: fix doc don't display two hyphens >>>>> >>>>> --- >>>>> v4: address Thomas's comment on 4/6 commit: >>>>> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and >>>>> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. >>>>> v3: >>>>> - address Thomas's comment on 4/6 comit. >>>>> - add commit: fix doc don't display two hyphens. >>>>> v2: address David Marchand's comment: >>>>> - replace flag enum with marco. >>>>> - replace flag's hardcode with macro in test_argparse.c. >>>>> >>>>> app/test/test_argparse.c | 65 +++++++++++--------- >>>>> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- >>>>> lib/argparse/rte_argparse.c | 61 +++++++++--------- >>>>> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- >>>>> 4 files changed, 127 insertions(+), 131 deletions(-) >>>> >>>> The verb refine is not usually used for edits to documents or software >>>> that probably is a translation issue. >>>> >>>> Series-acked-by: Stephen Hemminger <step...@networkplumber.org> >>> >>> Thank Stephen > > Added Bugzilla ID, CC: stable, reworded as Stephen suggests, > and applied.
Thanks > > Note that the lists in doxygen comments does not look nice. > You may look at this: https://www.doxygen.nl/manual/lists.html I'll look at it and push another commit if needed. > >
