Thomas, 2015-09-09 15:33 GMT+02:00 Thomas Monjalon <thomas.monjalon at 6wind.com>:
> 2015-09-09 15:10, N?lio Laranjeiro: > > I think V2 is better, maybe you can add a function to convert a single > > bitmap value to the equivalent integer and get rid of ETH_SPEED_XXX > macros. > > > > Thomas what is your opinion? > > Your proposal looks good Nelio. > I am confused, specially since you were the one advocating for having a unified set of constants for speeds (discussion in v2). In any case, as I see it, if we want to address the comments of M. Brorup: http://comments.gmane.org/gmane.comp.networking.dpdk.devel/19664 we need bitmaps for rte_eth_conf link_speed to set the advertised speeds. 857 struct rte_eth_conf { 858 uint16_t link_speed; 859 /**< ETH_LINK_SPEED_10[0|00|000], or 0 for autonegotation */ 860 uint16_t link_duplex; Let me know if you really want to come back to v2 or not. Marc > Thanks >