2015-09-16 21:22, De Lara Guarch, Pablo: > From: Ananyev, Konstantin > > Why not something like: > > ret = dev->dev_ops->tx_queue_start(dev, tx_queue_id); > > if (ret == 0) > > dev->data->tx_queue_state[tx_queue_id] = > > RTE_ETH_QUEUE_STATE_START; > > > > Same for dev_stop and RX. > > Then you hopefully wouldn't need to update each and every PMD, > > only rteh_ethdev* would be affected. > > Problem is that some PMDs call internally queue_start/stop, but not the > generic rte_eth_rx_queue_start (stop and RX), > so in that case this would not update the state of the queue.
Why not changing PMD to call rte_eth_rx_queue_start? Do you think it will be too much error prone for later updates?