> -----Original Message-----
> From: Stephen Hemminger <step...@networkplumber.org>
> Sent: Tuesday, October 29, 2024 6:23 PM
> To: Brandes, Shai <shaib...@amazon.com>
> Cc: ferruh.yi...@amd.com; dev@dpdk.org; Bernstein, Amit
> <amitb...@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH 1/1] net/ena: add histogram support
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> On Tue, 29 Oct 2024 10:02:15 +0200
> <shaib...@amazon.com> wrote:
> 
> > From: Shai Brandes <shaib...@amazon.com>
> >
> > The framework computes the differences between specified start and end
> > points in the code, providing insights into performance by outputting
> > a histogram of the time intervals.
> > The histogram can be used to track metrics like packet processing
> > latency in the network driver.
> > This framework requires enablement via a compilation flag and is
> > excluded in release builds by default.
> >
> > Signed-off-by: Amit Bernstein <amitb...@amazon.com>
> > Signed-off-by: Shai Brandes <shaib...@amazon.com>
> 
> Could this be generic for all PMD's and built off of existing DPDK trace
> mechanism?
> 
> Yes, histogram is useful.
> But IMHO DPDK should discourage PMD specific features.
[Brandes, Shai] Acknowledged, thanks for your insights!

Reply via email to