On Fri, 15 Nov 2024 09:07:42 +0000 Bruce Richardson <bruce.richard...@intel.com> wrote:
> On Thu, Nov 14, 2024 at 11:25:05AM -0800, Stephen Hemminger wrote: > > The expression for checking which lcore is enabled for 0-7 > > was wrong (missing case for 6). > > > > Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ > > > > Fixes: b0209034f2bb ("test/eal: check number of cores before running > > subtests") > > Cc: msant...@redhat.com > > Cc: sta...@dpdk.org > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > Just wondering would it not be better/safer to put in an actual loop check > here? > However, I'm also ok with keeping the fix as-is, so: > > Acked-by: Bruce Richardson <bruce.richard...@intel.com> My goal was to do minimum changes for now, to avoid introducing new bugs.