On 09/23/2015 06:46 AM, Yuanhan Liu wrote: > On Tue, Sep 22, 2015 at 05:51:02PM +0300, Marcel Apfelbaum wrote: [...] >>> It's proved to work after the fix (at least in my testing), but >>> it's late here and I'm gonna send a new version tomorrow, including >>> some other comments addressing. Please do more test then :) >>> > > It's unlikely that I will send another version unless I have clear clue > how to address a comment from Michael about vring flush.
Hi, I don't pretend to understand how exactly this works in DPDK, but since the objective is to not have packets in vring you could: 1. Disable the vq processing of new packets. (You introduced the 'enable' flag) 2. Wait a reasonable amount of time until the processing cores finish dealing with current packets. 3. Check the vqs that no packets are waiting for processing. Again, this is only a suggestion and may be incomplete (or naive). > > But anyway, you still could help me to prove the fix works. You can > apply the attachment on top of my old patchset, and it should work. > I tested it and it works just fine! Thanks again, Marcel > --yliu >> >> Those are very good news! >> Tomorrow we have holidays but the day after that I'll try it for sure. >