On Fri, 13 Dec 2024 14:57:23 +0800 "lihuisong (C)" <lihuis...@huawei.com> wrote:
> Hi Stephen, > > This patch looks good to me. > > But this test case still runs failure when I run "link_bonding_autotest" > twice. like: > --> > ... > EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure > for port 7 failed > EAL: Test assert initialize_bonding_device_with_members line 1138 > failed: Failed to configure bonding port (7) in mode 3 with (4) members. > EAL: Test assert > test_broadcast_verify_member_link_status_change_behaviour line 4060 > failed: Failed to initialise bonding device > + TestCase [62] : > test_broadcast_verify_member_link_status_change_behaviour failed > ETHDEV: Invalid port_id=7 > EAL: Test assert configure_ethdev line 181 failed: rte_eth_dev_configure > for port 7 failed > EAL: Test assert test_reconfigure_bonding_device line 4162 failed: > failed to reconfigure bonding device > + TestCase [63] : test_reconfigure_bonding_device failed > ETHDEV: Invalid port_id=7 > + TestCase [64] : test_close_bonding_device succeeded > ETHDEV: Invalid port_id=7 > EAL: Test assert remove_members_and_stop_bonding_device line 659 failed: > Failed to stop bonding port 7 > + ------------------------------------------------------- + > + Test Suite Summary : Link Bonding Unit Test Suite > + ------------------------------------------------------- + > + Tests Total : 65 > + Tests Skipped : 0 > + Tests Executed : 65 > + Tests Unsupported: 0 > + Tests Passed : 5 > + Tests Failed : 60 > + ------------------------------------------------------- + > Test Failed > > > I guess the bonding use case needs to close all bonding devices. The test has lots of issues that would make it bad to run twice. Like leaking mbufs, etc. But these always existed and will leave that to bonding maintainers to fix.
