19/12/2024 13:24, Akhil Goyal:
> > Some cryptodev functions were not included in the extern "C" block,
> > so it is moved to start before.
> >
> > An include is also moved to avoid being part of this block.
[...]
> > --- a/lib/cryptodev/rte_cryptodev.h
> > +++ b/lib/cryptodev/rte_cryptodev.h
> > @@ -21,6 +21,11 @@
> > #include <rte_rcu_qsbr.h>
> >
> > #include "rte_cryptodev_trace_fp.h"
> > +#include "rte_cryptodev_core.h"
>
> Fix is ok but rte_cryptodev_core.h should not be moved up.
> It is added in the middle to segregate the fast path APIs.
> And it is an internal header which cannot be included by app directly.
> I think the same schema is followed in ethdev as well.
Indeed, this is how it's done in ethdev:
#ifdef __cplusplus
}
#endif
#include <rte_ethdev_core.h>
#ifdef __cplusplus
extern "C" {
#endif
I'll do the same in v2.
