[PATCH v1 11/31] net/ntnic: add null checking

[Serhii Iliushyk]

From: Danylo Vodopianov <dvo-...@napatech.com>

Fix issue with potential rereferencing a pointer
that might be NULL p->m_rpp_lr when calling
nthw_module_query_register

CID 448923:  Dereference null return value (NULL_RETURNS)

Coverity issue: 448923
Fixes: f543ca6b9ab2 ("net/ntnic: add RPP local retransmit (RPP LR) flow module")

Signed-off-by: Danylo Vodopianov <dvo-...@napatech.com>
---
 drivers/net/ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c 
b/drivers/net/ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c
index 28c7a05fe2..e69a1ca823 100644
--- a/drivers/net/ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c
+++ b/drivers/net/ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c
@@ -54,18 +54,20 @@ int rpp_lr_nthw_init(struct rpp_lr_nthw *p, nthw_fpga_t 
*p_fpga, int n_instance)
        p->mp_fpga = p_fpga;
        p->m_physical_adapter_no = (uint8_t)n_instance;
        p->m_rpp_lr = nthw_fpga_query_module(p_fpga, MOD_RPP_LR, n_instance);
-
-       p->mp_rcp_ctrl = nthw_module_get_register(p->m_rpp_lr, RPP_LR_RCP_CTRL);
+       if (p->m_rpp_lr)
+               p->mp_rcp_ctrl = nthw_module_get_register(p->m_rpp_lr, 
RPP_LR_RCP_CTRL);
        p->mp_rcp_addr = nthw_register_get_field(p->mp_rcp_ctrl, 
RPP_LR_RCP_CTRL_ADR);
        p->mp_rcp_cnt = nthw_register_get_field(p->mp_rcp_ctrl, 
RPP_LR_RCP_CTRL_CNT);
-       p->mp_rcp_data = nthw_module_get_register(p->m_rpp_lr, RPP_LR_RCP_DATA);
+       if (p->m_rpp_lr)
+               p->mp_rcp_data = nthw_module_get_register(p->m_rpp_lr, 
RPP_LR_RCP_DATA);
        p->mp_rcp_data_exp = nthw_register_get_field(p->mp_rcp_data, 
RPP_LR_RCP_DATA_EXP);
 
        p->mp_ifr_rcp_ctrl = nthw_module_query_register(p->m_rpp_lr, 
RPP_LR_IFR_RCP_CTRL);
        p->mp_ifr_rcp_addr =
                nthw_register_query_field(p->mp_ifr_rcp_ctrl, 
RPP_LR_IFR_RCP_CTRL_ADR);
        p->mp_ifr_rcp_cnt = nthw_register_query_field(p->mp_ifr_rcp_ctrl, 
RPP_LR_IFR_RCP_CTRL_CNT);
-       p->mp_ifr_rcp_data = nthw_module_query_register(p->m_rpp_lr, 
RPP_LR_IFR_RCP_DATA);
+       if (p->m_rpp_lr)
+               p->mp_ifr_rcp_data = nthw_module_query_register(p->m_rpp_lr, 
RPP_LR_IFR_RCP_DATA);
        p->mp_ifr_rcp_data_ipv4_en =
                nthw_register_query_field(p->mp_ifr_rcp_data, 
RPP_LR_IFR_RCP_DATA_IPV4_EN);
        p->mp_ifr_rcp_data_ipv6_en =
-- 
2.45.0