On Thu, 9 Jan 2025 11:46:38 -0800 Joshua Washington <[email protected]> wrote:
> Kaligineedi <[email protected]> > > Allocating QPL for an RX queue might fail if enough contiguous IOVA > memory cannot be allocated. This can commonly occur when using 2MB huge > pages because the 1024 4K buffers are allocated for each RX ring by > default, resulting in 4MB for each ring. However, the only requirement > for RX QPLs is that each 4K buffer be IOVA contiguous, not the entire > QPL. Therefore, malloc will be used to allocate RX QPLs instead. > > Note that TX queues require the entire QPL to be IOVA contiguous, so it > will continue to use the memzone-based allocation. > > v2: Updated RX path to use malloc exclusively > > v3: Changed commit description to match updated code > > v4: Add fixes tag to allow 2M hugepages to be used on older versions of > DPDK > > Fixes: a46583cf43c8 ("net/gve: support Rx/Tx") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Praveen Kaligineedi <[email protected]> > Signed-off-by: Joshua Washington <[email protected]> > --- The standard practice is to put revision information below the cut line "---" so it doesn't end up in the commit message. I fixed that and applied it to next-net
