> -----Original Message----- > From: Junfeng Guo <[email protected]> > Sent: Thursday, February 20, 2025 08:09 > To: [email protected] > Cc: Dariusz Sosnowski <[email protected]>; Slava Ovsiienko > <[email protected]>; Bing Zhao <[email protected]>; Ori Kam > <[email protected]>; Suanming Mou <[email protected]>; Matan Azrad > <[email protected]>; Minggang(Gavin) Li <[email protected]>; Jiawei(Jonny) > Wang <[email protected]>; [email protected] > Subject: [PATCH] net/mlx5: fix err message overwrite for actions translation > > Function __flow_hw_translate_actions_template contains several encapsulated > functions that already have internal error handling process via > rte_flow_error_set > for each case. > > Thus the one (rte_flow_error_set) within the goto statement `err` at the end > of > __flow_hw_translate_actions_template function may be redundant for those > failed cases. As a result, the error messages would all be overwritten as > "fail to > create rte table", making it displayed at quite large granularity. > > To prevent above error messages overwrite, this patch add a local variable > `struct > rte_flow_error sub_error` to the function and pass this `sub_error` instead of > `error` to each sub-function. Under error handling process (`err` label), if > `sub_error` was updated, copy its contents to `error` and return. If it was > not > updated, return default error message (`fail to create rte table`). > > Also refactor the logic for SEND_TO_KERNEL, COUNT and AGE actions in above > function to align the error handling process. > > Fixes: f13fab23922b ("net/mlx5: add flow jump action") > Cc: [email protected] > Cc: [email protected] > > Signed-off-by: Junfeng Guo <[email protected]>
Acked-by: Dariusz Sosnowski <[email protected]> Best regards, Dariusz Sosnowski
